Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROScopter Command Messages are Misleading #69

Open
natetoombs opened this issue Nov 12, 2021 · 0 comments
Open

ROScopter Command Messages are Misleading #69

natetoombs opened this issue Nov 12, 2021 · 0 comments

Comments

@natetoombs
Copy link
Contributor

The first message mode is MODE_NPOS_EPOS_DPOS_YAW, which is fine; it commands the NED position and yaw. However, starting with the next mode (MODE_NVEL_EVEL_DPOS_YAWRATE), the velocities that are commanded are no longer in the inertial frame, but in the vehicle 1 frame (translated to the body, then yawed). While the down position "DPOS" or velocity/acceleration in other message modes is correct because the k axis of the v1 frame aligns with the down direction of the inertial frame, it seems wrong to have the message say "NVEL" or later "NACC" when the command is in the v1 frame, so not necessarily north.

It looks like the controller uses x, y, z as the v1 frame coordinates. Would it be appropriate to rename the command modes to align with that notation? Or should the controller be changed to use inertial frame coordinates, because maybe it would be more valuable to command velocity and accelerations in north and east directions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant