-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output OG 1.0 #21
Comments
Hi Callum, I'm currently looking into outputing in OG1.0 format. Do you know if any work have been done on this so far in pyglider? |
I haven't tried yet, but it would be good to figure out what is currently not supported. I'd think og1.0 is 95% supported already just someone needs to make a yaml example. |
ok, thanks jody. will have a look |
Hi all! @clayton33 has made some progress with code (outside of pyglider) to convert the pyglider nc files to an OG1.0 compliant version. We are still wrapping up our processing pipeline, and weren't sure if this is something that should propagate back into pyglider or not, but this might be a good time to discuss. @clayton33 -- can you provide a brief overview of how you're handling this at the moment? |
Is there a reason to not just modify the yaml to have the OG1.0 compatible names and metadata? It should work fine. OG1.0 also has quality flags, which we do not populate, but maybe would be a simple addition. |
@clayton33 can correct me on this, but the reason we converted them after was to have both available (as we are still trying to sort out exactly where the files are going to end up and what format will be required). But yes, modifying the yaml should also work, I believe. |
From my experience so far, nothing needs to be changed in
but for IOOS variables, the main ones being pressure, temperature, conductivity, and salinity, you'll have to change this after it's processed. As an example, temperature in the
you'll see I have something called |
If you are willing it might be nice to share that utility via pyglider. I think the todos here are
TEMP:
origname: temperature
renamed_attr:
attr_name1_old: attr_name1_new
attr_name2_old: attr_name2_new
copied_attr:
attr_name3_old : attr_name21_new
dropped_attr:
attr_name4_old
attr_name5_old
newattr1: attr1_value Not sure how much attribute renaming/copying would have to happen, but could be useful in other contexts.. |
We've been working with a similar process to @clayton33 to post-process our files into OG1 format. It would be good to upstream these changes into pyglider though. I'll work on making a compliant yaml file and example to ship with pyglider as @jklymak suggests. I'm not sure all the things OG1 requires can be achieved with yaml, but I'll try to minimise changes to the codebase |
I am slowly shoring up a data pipeline for UAF for glider processing using pyglider. One of these tasks is to ensure compliance with as much of the OG-1.0 checker as possible. I did this with a different pipeline already. I would have to port all this over to the slocum.py driver and as well define that in yaml. Anyway, just saying we also have a parallel track that will hopefully converge with everyone else. I just shored up pyglider to at least be compliant with cf-1.8 and ngdac 2.0. Just need to be sure things are working at UAF before sending additional PRs here. Refreshing the existing PR #163 for compliance. |
Just out of curiosity, are any glider DACs ingesting OG1.0 yet? |
We're about to start pushing DFO glider data to CIOOS, and I'm going to insist that they ingest OG1.0 😄 |
Ultimately, we should aim for the OceanGliders 1.0 format https://github.com/OceanGlidersCommunity/OG-format-user-manual
This will take some time. If you spot an atomic change that can be made to move toward OG 1.0, please submit an Issue for it
The text was updated successfully, but these errors were encountered: