Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST JSON: Malformed output missing commas #1538

Open
Caleb-o opened this issue Oct 10, 2024 · 4 comments
Open

AST JSON: Malformed output missing commas #1538

Caleb-o opened this issue Oct 10, 2024 · 4 comments
Labels
Bug Something isn't working

Comments

@Caleb-o
Copy link
Contributor

Caleb-o commented Oct 10, 2024

Some of the output is missing commas, which makes invalid JSON.

image

@lerno lerno added the Bug Something isn't working label Oct 11, 2024
@hwchen
Copy link
Contributor

hwchen commented Oct 12, 2024

@Caleb-o I'm fixing some of the commas, but I can't reproduce your example (a struct with what appears to be a list of members as just strings). Can you give your code snippet?

For example, for me

struct Point {
	int x;
	int y;
}

results in

        "types": {
                "example::Point": {
                        "kind": "struct",
                        "members": [
                                {
                                        "name:": "x",
                                        "type:": "Point"
                                },
                                {
                                        "name:": "y",
                                        "type:": "Point"
                                }
                        ]
                }
        },

@Caleb-o
Copy link
Contributor Author

Caleb-o commented Oct 12, 2024

@hwchen I just tried running this again and it would seem it has been fixed now?

@hwchen
Copy link
Contributor

hwchen commented Oct 12, 2024

Oh, I see now 1adad86

I have some additional fixes up at #1550

@lerno
Copy link
Collaborator

lerno commented Nov 16, 2024

Is this fixed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants