Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main README,md does not link to CONTRIBUTING.md #10694

Open
Steveolas opened this issue Mar 7, 2024 · 1 comment
Open

Main README,md does not link to CONTRIBUTING.md #10694

Steveolas opened this issue Mar 7, 2024 · 1 comment

Comments

@Steveolas
Copy link

On the README.md file on the organization page https://github.com/cBioPortal. the relative link to CONTRIBUTING.md is faulty as the file does not exist in https://github.com/cBioPortal/.github/blob/main/. The file does exist though in here: https://github.com/cBioPortal/cbioportal/blob/master/CONTRIBUTING.md.

Two possible solutions are to:

  1. Create a CONTRIBUTING.md file in the cBioPortal organization directory.
  2. Change the in the README.md file to link to the correct place

I think the first solution is better this way the README.md files remain consistent.

@Steveolas
Copy link
Author

As the README.md files in the https://github.com/cBioPortal organization page is different than the README.md file in the https://github.com/cBioPortal/cbioportal repository I have opted to fix the issue with the first solution I suggested. I have created a pull request to fix this.

This is my first pull request ever so any feedback on how things could have been done better will be appreciated!
Ilan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant