Move SessionRepository classes to repository package #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes it from session-service dependency jar, so that application context probles are avoided.
inodb
approved these changes
Oct 11, 2021
|
@inodb Comment added to description. |
pvannierop
added a commit
to pvannierop/cbioportal
that referenced
this pull request
Oct 12, 2021
pvannierop
added a commit
to pvannierop/cbioportal
that referenced
this pull request
Dec 15, 2021
pvannierop
added a commit
to pvannierop/cbioportal
that referenced
this pull request
Dec 15, 2021
pvannierop
added a commit
to pvannierop/cbioportal
that referenced
this pull request
Dec 15, 2021
Luke-Sikina
approved these changes
Nov 22, 2022
|
What verification should we do before we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44
Removes SessionRepositoryImpl.java from session-service dependency jar, so that application context problems are avoided.
Edit:
The application context problem is caused by SessionRepositoryImpl.java requiring a MongoTemplate bean. The MongoTemplate bean is created when the application is configured to access a mongoDB instance. Because of this projects that merely require the domain information of session-service, are required to somehow to configure a MongoDB connection in order to create a MongoTemplate bean. The migration of SessionRepositoryImpl.java to a different package will avoid exporting this class in the domain/model jar so that the dependency will no longer require the application to create a MongoTemplate bean.