From d4714e75263285691d08b447a238a2690279d1d2 Mon Sep 17 00:00:00 2001 From: Carlos Alexandro Becker Date: Thu, 5 Dec 2024 23:30:10 -0300 Subject: [PATCH] test: improve --- internal/roundrobin/roundrobin_test.go | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/internal/roundrobin/roundrobin_test.go b/internal/roundrobin/roundrobin_test.go index 9234648..55ba02a 100644 --- a/internal/roundrobin/roundrobin_test.go +++ b/internal/roundrobin/roundrobin_test.go @@ -24,7 +24,7 @@ func TestRoundRobin(t *testing.T) { a, b, c, d := exercise(t, rr, 100) for _, n := range []int64{a, b, c, d} { - requireWithinRange(t, n, 23, 27) + requireWithinRange(t, is, n, 23, 27) } is.Equal(int64(100), a+b+c+d) } @@ -37,8 +37,8 @@ func TestRoundRobinWithInvalidatedKeys(t *testing.T) { a, b, c, d := exercise(t, rr, 100) is.Equal(a, int64(0)) is.Equal(b, int64(0)) - requireWithinRange(t, c, 48, 52) - requireWithinRange(t, d, 48, 52) + requireWithinRange(t, is, c, 48, 52) + requireWithinRange(t, is, d, 48, 52) } func TestTokenString(t *testing.T) { @@ -78,11 +78,10 @@ func invalidateN(t *testing.T, rr RoundRobiner, n int) { } } -func requireWithinRange(t *testing.T, n, min, max int64) { +func requireWithinRange(t *testing.T, is *is.I, n, low, high int64) { t.Helper() - is := is.New(t) - is.True(n >= min) // n should be at least min - is.True(n <= max) // n should be at most max + is.True(n >= low) // n should be at least min + is.True(n <= high) // n should be at most max } func exercise(t *testing.T, rr RoundRobiner, n int) (int64, int64, int64, int64) {