-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Make default interactive HTML elements accessible. #933
Comments
[x] sidebar button is now a button element and has an outline and can be used with enter |
where do you see links that are not |
This feature request is not just the sidebar or cables editor UI but for end-user created UI. But if in the DOM it's a <div> and not a <button> or a <link> then it won't have default accessible behaviour that the browser would assign to it. To make a <div> equivalent to a <link> in terms of accessibility I think it has to have role="link" and tabindex="0" and register an event handler for click. I advocate that this should just be the default behaviour without needing a special ElementAccessibility op. It should be that if the end user creates an interactive HTML element that is as accessible as possible by default and they have to work to mess it up, as opposed to adding extra ops to make it accesible. So specifically would suggest
And then in terms of the default semantic behaviour it's about what should the default easy way for cables.gl users to create buttons and links be? If they should be using the Element op then I think should have a tag dropdown between <link>, <button>, <div> and other (with then a user field for other) OR perhaps there should be simple LinkElement and ButtonElement ops fixed to the appropriate tags. |
when an element op is interactive, they now (on dev.cables.gl) get a tabindex attribute and are "clickable" by keyboard space/enter keys |
Sounds good! Does it use the 'click' event handler? Unfortunately I don't have an ios device any more. |
Currently DivElement and Element ops can be set to interactive mode where they are effectively buttons (or links if they subsequently open a hyperlink).
These have two accessibility issues at the moment
This would also go for any other HTML ops in future.
It also may be that different 'ButtonElement' 'LinkElement' ops are a better approach.
The text was updated successfully, but these errors were encountered: