Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API GET Request with API Key #235

Open
taepp-do opened this issue Feb 7, 2025 · 2 comments · May be fixed by #236
Open

API GET Request with API Key #235

taepp-do opened this issue Feb 7, 2025 · 2 comments · May be fixed by #236
Milestone

Comments

@taepp-do
Copy link

taepp-do commented Feb 7, 2025

Hello, I know you want the Get requests public but we will use internally and no one else should access the data, because its sensitive data. Could you tell me where the API Requests are happening so I can change the code that get requests also need the api key?

Thanks for your help in advance

@icecoldPHP
Copy link
Contributor

@taepp-do
The API request are done in the Core package:
https://github.com/cachethq/core

specific: https://github.com/cachethq/core/blob/main/routes/api.php:41

But i guess this would be a great option to add to the application.
That the API can be public or protected

@jbrooksuk
Copy link
Member

This would need to be an option in the core repo, that allows the API to be private.

@jbrooksuk jbrooksuk transferred this issue from cachethq/cachet Feb 8, 2025
@jbrooksuk jbrooksuk added this to the v3.0 milestone Feb 8, 2025
@icecoldPHP icecoldPHP linked a pull request Feb 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants