Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interop with mkDerivation's checkPhase? #289

Open
edrex opened this issue Apr 25, 2023 · 1 comment
Open

Interop with mkDerivation's checkPhase? #289

edrex opened this issue Apr 25, 2023 · 1 comment

Comments

@edrex
Copy link

edrex commented Apr 25, 2023

Follow-up to #277 (comment).

It seems that the best place to configure a make-based project's tests is via mkDerivation's checkPhase.

It's unclear how best to interoperate between pre-commit hooks and checkPhase though. I think I'd like to have package tests run in a pre-commit hook. Maybe also flake checks. pre-commit.check.enable seems backwards IIUC. pre-commit should run flake stuff, not the other way around.
@domenkozar
Copy link
Member

pre-commit run -a?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edrex @domenkozar