Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append install_options? #74

Open
JackKelly-Bellroy opened this issue Apr 27, 2021 · 2 comments
Open

Append install_options? #74

JackKelly-Bellroy opened this issue Apr 27, 2021 · 2 comments

Comments

@JackKelly-Bellroy
Copy link

It appears that flags specified with install_options are prepended to the argument list that gets passed to the installer:

https://github.com/cachix/install-nix-action/blob/master/lib/install-nix.sh#L32

This means that the hardcoded --daemon will override any --no-daemon passed into as an install_option. Perhaps it would be better to append install_options to the end of the list?

@domenkozar
Copy link
Member

It's prepending because --tarbal-url is only handled as the first argument. If we fixed that in Nix it could append.

@JackKelly-Bellroy
Copy link
Author

It turns out I didn't end up needing a non-daemon install, so I'm happy to leave this open or close it or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants