Skip to content

Refactor History/Visibility Archiver implementation #3001

Open
@yycptt

Description

@yycptt

Now we have three implementations for the history archiver interface (filestore, s3 and gcp) and two implementations for the visibility archiver interface (filestore and s3). They all look quite similar and share lots of common utility functions.

We can move those common functions to the archiver package so that they can be reused. We can also consider abstract some common structure into a new component.

Also consider adding a context.Context parameter to the ValidateURI method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    archivalWorkflow history archivalrefactoringCode refactoringup-for-grabsIssues that are good entry points for those new to Cadence that want to contribute

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions