Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ';' in generated query #2340

Open
Yopai opened this issue Feb 4, 2025 · 0 comments
Open

Remove ';' in generated query #2340

Yopai opened this issue Feb 4, 2025 · 0 comments

Comments

@Yopai
Copy link

Yopai commented Feb 4, 2025

Hi,

=== Context
Phinx :) for this work.

I'm writing an Adapter for PDO-OCI.

I'm getting blocked by some things that should be fixed in

=== Observed behaviour
In the PDO adapter, migrated generates a query with a semi-colon at the end. ';' is a query separator, and is not allowed by PDO-OCI (ORA-00911 - Invalid character)

=== Expected behaviour
I would ask to remove this ';', given that it won't change anything for other databases.

I have patched it manually (by overriding it in the OCIAdapter I have created) for now, I will push a PR for that when I'll have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant