Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Resources as HTML #271

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Feat: Resources as HTML #271

merged 3 commits into from
Nov 2, 2023

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Nov 1, 2023

Closes #267

This PR adds support for hosting Resource pages as HTML.

To create the resource layout, I just copy-and-pasted from the press layout, and then I removed some things that don't apply to Resources. I referenced the resource from #266 to see what doesn't apply.

For testing purposes, I made a file at src/_resources/test.md with these contents:

---
date: "2022-11-01T17:00:00-07:00"
title: |-
  this is a test from Angela
category: Case studies
tags:
  - Contactless Payments
---

blah blah blah

**bold**

1. apples
1. bananas
1. carrots

and here's what it looks like:

image

Here is what the link to that HTML resource on the Resources page looks like:

image

@angela-tran angela-tran requested a review from a team as a code owner November 1, 2023 22:20
@angela-tran angela-tran self-assigned this Nov 1, 2023
Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 785e31e
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/6542d06695c0b90008ff3f6a
😎 Deploy Preview https://deploy-preview-271--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@angela-tran angela-tran added this to the Resources update milestone Nov 1, 2023
@angela-tran angela-tran marked this pull request as draft November 1, 2023 22:22
@angela-tran angela-tran force-pushed the feat/resources-as-html branch from 8d3db88 to 785e31e Compare November 1, 2023 22:25
@angela-tran angela-tran marked this pull request as ready for review November 1, 2023 22:26
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the following in src/_resources/test.md:

---
date: "2022-11-01T17:00:00-07:00"
title: |-
  This is a test from Kegan
category: Case studies
tags:
  - Contactless Payments
---

## Subheading

> Some important intro line that pops

## Another Section

blah blah blah

### Subsection here

**bold**

1. apples
1. bananas
1. carrots

image

@angela-tran angela-tran merged commit 8648ab3 into main Nov 2, 2023
5 checks passed
@angela-tran angela-tran deleted the feat/resources-as-html branch November 2, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for hosting Resources as html on calitp.org
2 participants