Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add ZEB resource #329

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Feat: add ZEB resource #329

merged 2 commits into from
Apr 16, 2024

Conversation

thekaveman
Copy link
Member

Closes #325

@thekaveman thekaveman self-assigned this Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit e6044b9
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/661efce7d232f000083343b8
😎 Deploy Preview https://deploy-preview-329--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thekaveman thekaveman marked this pull request as ready for review April 16, 2024 22:31
@thekaveman thekaveman requested a review from a team as a code owner April 16, 2024 22:31
@thekaveman thekaveman requested a review from mrose914 April 16, 2024 22:31
@thekaveman
Copy link
Member Author

Copy link

@mrose914 mrose914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it seems the drive link didn't get replaced correctly. Please use the file now linked here: https://drive.google.com/file/d/1Td0R1Q10QE5DY6V06o0LBFVzqZsMaM9Z/view?usp=sharing

Thank you!!

@thekaveman
Copy link
Member Author

thekaveman commented Apr 16, 2024

Can you please check again? I had updated seconds after I sent you the message 😅 I used the one from your most recent comment: #325 (comment) is that right?

@mrose914
Copy link

Yup, that is the one! Approved, thank you 🤓

@thekaveman
Copy link
Member Author

@mrose914 can you please mark Approved? The merge is blocked with your requested changes.

@thekaveman thekaveman requested a review from mrose914 April 16, 2024 22:50
@thekaveman thekaveman merged commit 0ab3ca4 into main Apr 16, 2024
5 checks passed
@thekaveman thekaveman deleted the feat/zeb branch April 16, 2024 22:55
@thekaveman
Copy link
Member Author

FYI @angela-tran I temporarily allowed myself to bypass the Approval requirement from @cal-itp/web-admin, to make this resource available ASAP for those at the conference this week.

I had to enable this bypass allowance in the branch protection rules for main, then put it back to disabled when I was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posting the Caltrans ZEB Market Sounding report
2 participants