Skip to content

Commit 00606e4

Browse files
fsalemifarhad
andauthored
Fix: ensure FLOAT64 percentage handling for wheelchair accessibility guideline checks (#4416)
Co-authored-by: farhad <[email protected]>
1 parent 131b34b commit 00606e4

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

warehouse/models/intermediate/gtfs_quality/guidelines_checks/int_gtfs_quality__wheelchair_accessible_trips.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ feed_trips_summary AS (
1313
feed_key,
1414
COUNTIF(wheelchair_accessible IS NOT NULL AND CAST(wheelchair_accessible AS STRING) != "0") AS ct_trips_accessibility_info,
1515
COUNT(*) AS ct_trips,
16-
ROUND(COUNTIF(wheelchair_accessible IS NOT NULL AND CAST(wheelchair_accessible AS STRING) != "0")/COUNT(*)*100, 1) AS percentage
16+
ROUND(COUNTIF(wheelchair_accessible IS NOT NULL AND CAST(wheelchair_accessible AS STRING) != "0")/COUNT(*)*100, 2) AS percentage
1717
FROM dim_trips
1818
GROUP BY feed_key
1919
),

warehouse/models/intermediate/gtfs_quality/guidelines_checks/int_gtfs_quality__wheelchair_boarding_stops.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ feed_stops_summary AS (
1313
feed_key,
1414
COUNTIF(wheelchair_boarding IS NOT NULL AND CAST(wheelchair_boarding AS STRING) != "0") AS ct_stops_accessibility_info,
1515
COUNT(*) AS ct_stops,
16-
ROUND(COUNTIF(wheelchair_boarding IS NOT NULL AND CAST(wheelchair_boarding AS STRING) != "0")/COUNT(*) *100, 1) AS percentage
16+
ROUND(COUNTIF(wheelchair_boarding IS NOT NULL AND CAST(wheelchair_boarding AS STRING) != "0")/COUNT(*) *100, 2) AS percentage
1717
FROM dim_stops
1818
GROUP BY feed_key
1919
),

warehouse/models/intermediate/gtfs_quality/int_gtfs_quality__guideline_checks_long.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ unioned AS (
5555
ref('int_gtfs_quality__wheelchair_accessible_trips'),
5656
ref('int_gtfs_quality__wheelchair_boarding_stops')
5757
],
58-
include = ['date', 'key', 'check', 'status', 'percentage']
58+
include = ['date', 'key', 'check', 'status', 'percentage'],
59+
column_override={"percentage": "FLOAT64"}
5960
) }}
6061
),
6162

0 commit comments

Comments
 (0)