Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Acceptance Criteria for Visual Changes to PR Template #151

Open
acouch opened this issue Jun 1, 2022 · 2 comments
Open

Add Acceptance Criteria for Visual Changes to PR Template #151

acouch opened this issue Jun 1, 2022 · 2 comments

Comments

@acouch
Copy link
Contributor

acouch commented Jun 1, 2022

Is your feature request related to a problem? Please describe.
We don't have a documented AC for visual changes.

Describe the solution you'd like
Add AC for visual changes to PR template.

This should include the breakpoints we want to focus on for now.

Longer term we may add an end to end test like Cypress, visual regression tests, pa11y or other tests.

@thekaveman
Copy link
Member

cc @srhhnry @machikoyasuda @mrose914 @vykster

Especially as @srhhnry and @machikoyasuda work to research standards around State/Fed design systems and guidelines, including breakpoints. Much work documented/happening in cal-itp/benefits#583 and cal-itp/services-team#6.

We should be in alignment across all Cal-ITP web properties.

@acouch
Copy link
Contributor Author

acouch commented Jun 1, 2022

@thekaveman Thanks for the resources. Agreed it would be ideal to have a standard of tools and practices across the projects. Will work to align any time we have the opportunity. If there is anything specific here let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants