Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordpress inline embed not working #12

Open
nimatris opened this issue Mar 14, 2024 · 11 comments · May be fixed by #13
Open

wordpress inline embed not working #12

nimatris opened this issue Mar 14, 2024 · 11 comments · May be fixed by #13

Comments

@nimatris
Copy link

nimatris commented Mar 14, 2024

When I use the shortcode, it shows a blank page.
The type 2 button for the popup works.
Also, if I copy the html inline embed it doesn't show anything.

Any ideas? Might be a conflict with my theme (one page express)?

Thank you!

This is the code that is shown on the source file for the empty page:

Bildschirmfoto 2024-03-14 um 10 31 00
@AdamBorealis
Copy link

AdamBorealis commented Mar 15, 2024

Hoping to get more eyes on this, as this was noted almost a year ago here:
https://wordpress.org/support/topic/uncaught-referenceerror-cal-is-not-defined/

I still get marketing emails, but can't use the plugin until it actually works. ;)

@zomars
Copy link
Member

zomars commented Mar 22, 2024

Is it only the inline embed that doesn't work? Can you provide an example link? Sounds like the head scripts aren't being run before the shortcode.

@nimatris
Copy link
Author

Hey Omar, it is the only that I have tried so far.
This is the page, but currently I use the type 2 so that it is functional for my clients:
https://www.jonathanklodt.com/book-a-60-min-call/

@milospuac
Copy link

@hariombalhara @zomars what is the verdict here?

@zomars
Copy link
Member

zomars commented May 7, 2024

Hey Omar, it is the only that I have tried so far. This is the page, but currently I use the type 2 so that it is functional for my clients: jonathanklodt.com/book-a-60-min-call

This seems to be resolved:

image

@nimatris
Copy link
Author

nimatris commented May 7, 2024

No, it's not 🫤
I just had the plugin shortcode set to type 2, which shows the button. That worked all the time, but the inline embed with type 1 still doesn't work and shows an empty page. Just tried it again...

Bildschirmfoto 2024-05-07 um 15 06 40 As you can see, you can see… nothing. ☝️

@CodeShakingSheep CodeShakingSheep linked a pull request Jun 18, 2024 that will close this issue
@CodeShakingSheep
Copy link
Contributor

Hi @nimatris,
@zomars is right that this issue has been resolved in #4 . The issue is just that there hasn't been a release of a new plugin version since this fix.

I can see from the code you posted in your initial post that it's the old code from before the fix. So, as a workaround instead of installing the cal.com plugin directly in WordPress you could download the ZIP file from this repository and upload it manually to your WordPress site.

@nimatris
Copy link
Author

Thank you @CodeShakingSheep and @zomars!
I tried that and now see that I have Version 1.0.1 instead of previously Version 1.0.0 installed.
But it still shows an empty page. Maybe it is a problem with my template...
I'll just continue using the popup button, that seems to work for most devices and browsers without messing up the responsive design like the iFrame does.

@CodeShakingSheep
Copy link
Contributor

Thank you @CodeShakingSheep and @zomars! I tried that and now see that I have Version 1.0.1 instead of previously Version 1.0.0 installed. But it still shows an empty page. Maybe it is a problem with my template... I'll just continue using the popup button, that seems to work for most devices and browsers without messing up the responsive design like the iFrame does.

As the change is in JS you need to empty your cache for the new script to load. If you use a chrome based browser you can do that by hitting "F12", then right click on the reload button of your page and then click "Empty cache and hard reload". If you use a WordPress caching plugin you should empty its cache too. Let me know if that works.

@nimatris
Copy link
Author

Thank you @CodeShakingSheep for that tip, still didn't work, also tried the page in a different browser.

@Ys-sudo
Copy link

Ys-sudo commented Aug 9, 2024

#13 - this one fixed it you can apply it manually to the file and the inline option will work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants