Added a check for not printing the whole table when more than 50 images are optimized. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are optimized.
|
|
|
@lfgcampos, in a bit of a turn around (sorry!) I'm going to close this PR. I've decided we should take a different approach and make it so that only images that are changed by a PR are processed, rather than all of them (#92). We still appreciate your effort and work. Sorry this one wasn't accepted. |
|
@benschwarz thanks for tagging me! For my use case, I tend to commit/push around 300 images at the same time. Only running the action on those are fine and desirable but still, the table will break the same and I won't be able to have the statistics as we have today. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
As discussed on #107, this PR added a check on the table to not print it when there are more than 50 images optimised.
Also adds the number of optimised images in case the table is not present.
Please, carefully check the markdown syntax as I was not 100% sure about it =)
Related issues
Closes #107.
Screenshots
If this work introduces any visual changes, add screenshots to portray them.
Reviewers