-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Common Regex Patterns #73
Comments
@PaulJPhilp awesome. Please send me some link to the code and I'll take a look. |
Maciej: Sorry for the delay. I ran into a bug (bug report to follow). Here is my repo with the partially completed URL pattern. Please let me know your feedback. https://github.com/PaulJPhilp/ts-regex-builder Thank you, |
@PaulJPhilp you're definitely going in the good directions. The difficulty of the task, imo lies in the fact that URL is a complex pattern built from different smaller patterns, and it's a tedious work to get all of these right. I've lefts some comments on the last commit: PaulJPhilp@0fdbf6c#diff-350009127029ecbdcc6940f99827bae2f3ece87b095a287c48db47ace9ef363dR43 BTW Pls create PR next, time, as it's make review and discussion happen in one, well defined place. |
Is your feature request related to a problem? Please describe.
Provide regex patterns for common use cases like:
Each pattern should be available in two versions:
Describe the solution you'd like
Patterns will be imported through
ts-regex-builder/patterns
import. See #72 for implementation of that part.Whole library is and should remain tree-shakable, so that unused patterns (and features) are removed by bundlers in order to reduce bundle size.
Describe alternatives you've considered
Checklist (for each pattern)
CC: @PaulJPhilp
The text was updated successfully, but these errors were encountered: