refactor: cleanup

Author: paradowstack

packages/node-addon-examples/tests/make_callback/CMakeLists.txt

@@ -12,4 +12,4 @@ target_compile_features(addon PRIVATE cxx_std_17)
 if(MSVC AND CMAKE_JS_NODELIB_DEF AND CMAKE_JS_NODELIB_TARGET)
   # Generate node.lib
   execute_process(COMMAND ${CMAKE_AR} /def:${CMAKE_JS_NODELIB_DEF} /out:${CMAKE_JS_NODELIB_TARGET} ${CMAKE_STATIC_LINKER_FLAGS})
-endif()
+endif()

packages/node-addon-examples/tests/make_callback/addon.c

@@ -65,4 +65,4 @@ static napi_value Init(napi_env env, napi_value exports) {
   return exports;
 }
 
-NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
+NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)

packages/node-addon-examples/tests/make_callback/addon.js

@@ -48,56 +48,4 @@ module.exports = () => {
     makeCallback(resource, process, myMultiArgFunc, 1, 2, 3),
     42
   );
-
-  // TODO(node-api): napi_make_callback needs to support
-  // strings passed for the func argument
-  //
-  // const recv = {
-  //   one: function () {
-  //     assert.strictEqual(0, arguments.length);
-  //     assert.strictEqual(this, recv);
-  //     return 42;
-  //   },
-  //   two: function (x) {
-  //     assert.strictEqual(1, arguments.length);
-  //     assert.strictEqual(this, recv);
-  //     assert.strictEqual(x, 1339);
-  //     return 42;
-  //   },
-  // };
-
-  // assert.strictEqual(makeCallback(recv, "one"), 42);
-  // assert.strictEqual(makeCallback(recv, "two", 1337), 42);
-  //
-  // Check that callbacks on a receiver from a different context works.
-  // const foreignObject = vm.runInNewContext('({ fortytwo() { return 42; } })');
-  // const foreignObject = { fortytwo: () => 42 };
-  // assert.strictEqual(makeCallback(foreignObject, "fortytwo"), 42);
-
-  // Check that the callback is made in the context of the receiver.
-
-  // const target = vm.runInNewContext(`
-  //     (function($Object) {
-  //       if (Object === $Object)
-  //         throw new Error('bad');
-  //       return Object;
-  //     })
-  // `);
-  // assert.notStrictEqual(makeCallback(resource, process, target, Object), Object);
-
-  // // Runs in inner context.
-  // const forward = vm.runInNewContext(`
-  //     (function(forward) {
-  //       return forward(Object);
-  //     })
-  // `);
-
-  // // Runs in outer context.
-  // function endpoint($Object) {
-  //   if (Object === $Object)
-  //     throw new Error('bad');
-  //   return Object;
-  // }
-
-  // assert.strictEqual(makeCallback(resource, process, forward, endpoint), Object);
 };