From 2d996885fcf9124341cfc2fa975747cf53f092ad Mon Sep 17 00:00:00 2001 From: Ayaka Yorihiro Date: Mon, 18 Nov 2024 15:28:30 -0500 Subject: [PATCH] Some comments and fixing clippy bugs --- calyx-opt/src/passes/profiler_instrumentation.rs | 4 ++-- tools/profiler/new-parse-vcd.py | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/calyx-opt/src/passes/profiler_instrumentation.rs b/calyx-opt/src/passes/profiler_instrumentation.rs index a4cfa11ee..b888cfe06 100644 --- a/calyx-opt/src/passes/profiler_instrumentation.rs +++ b/calyx-opt/src/passes/profiler_instrumentation.rs @@ -148,7 +148,7 @@ impl Visitor for ProfilerInstrumentation { guard.clone(), ); group_name_assign_and_cell.push(( - parent_group.clone(), + *parent_group, probe_asgn, probe_cell, )); @@ -178,7 +178,7 @@ impl Visitor for ProfilerInstrumentation { Guard::True, ); group_name_assign_and_cell.push(( - invoker_group.clone(), + *invoker_group, probe_asgn, probe_cell, )); diff --git a/tools/profiler/new-parse-vcd.py b/tools/profiler/new-parse-vcd.py index 77396a3c3..7bd3e65ae 100644 --- a/tools/profiler/new-parse-vcd.py +++ b/tools/profiler/new-parse-vcd.py @@ -370,6 +370,7 @@ def create_tree(timeline_map): path_dict = {} # stack list string --> list of node ids path_prefixes_dict = {} # stack list string --> list of node ids stack_list = [] + # collect all of the stacks from the list. (i.e. "flatten" the timeline map values.) for sl in timeline_map.values(): for s in sl: if s not in stack_list: @@ -437,6 +438,7 @@ def create_output(timeline_map, out_dir): for stack in stacks: flame_out.write(f"{stack} {stacks[stack]}\n") + # probably wise to not have a billion dot files. if len(timeline_map) > TREE_PICTURE_LIMIT: print(f"Simulation exceeds {TREE_PICTURE_LIMIT} cycles, skipping trees...") return