From 81d1d7b1d33198b73382e5d55740c1ddaf1e2deb Mon Sep 17 00:00:00 2001 From: Ayaka Yorihiro Date: Wed, 4 Dec 2024 16:58:19 -0500 Subject: [PATCH] clean up comments --- calyx-opt/src/passes/profiler_instrumentation.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/calyx-opt/src/passes/profiler_instrumentation.rs b/calyx-opt/src/passes/profiler_instrumentation.rs index c6254cd23..1e23aad8e 100644 --- a/calyx-opt/src/passes/profiler_instrumentation.rs +++ b/calyx-opt/src/passes/profiler_instrumentation.rs @@ -140,7 +140,6 @@ impl Visitor for ProfilerInstrumentation { let mut group_name_assign_and_cell = Vec::with_capacity(acc); { // probe and assignments for group (this group is currently active) - // FIXME: probably best to remove the code clone by extracting this out into a different function? for group_name in group_names.into_iter() { // store group and component name (differentiate between groups of the same name under different components) let name = format!( @@ -214,7 +213,6 @@ impl Visitor for ProfilerInstrumentation { probe_cell .borrow_mut() .add_attribute(BoolAttr::Protected, 1); - // FIXME: the assignment needs to take on the guard of the assignment and not the child group being done let probe_asgn: ir::Assignment = builder .build_assignment( probe_cell.borrow().get("in"), @@ -248,7 +246,7 @@ impl Visitor for ProfilerInstrumentation { probe_cell .borrow_mut() .add_attribute(BoolAttr::Protected, 1); - // FIXME: for correctness we'd probably want to get the go guard of the cell, but it doesn't *really* matter for the first pass + // NOTE: this probe is active for the duration of the whole group. Hence, it may be active even when the cell itself is inactive. let probe_asgn: ir::Assignment = builder .build_assignment( probe_cell.borrow().get("in"),