From 2eeb5bda5cfacc26a8333655c3abc2e39b828372 Mon Sep 17 00:00:00 2001 From: PEDRO DIEZ GARCIA Date: Wed, 6 Nov 2024 17:52:12 +0100 Subject: [PATCH 1/2] Avoid phoneNumber as query param in Blockchain Public Addresses Retrieval --- .../blockchain-public-address.yaml | 22 ++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/code/API_definitions/blockchain-public-address.yaml b/code/API_definitions/blockchain-public-address.yaml index 8058222..44558be 100644 --- a/code/API_definitions/blockchain-public-address.yaml +++ b/code/API_definitions/blockchain-public-address.yaml @@ -47,8 +47,8 @@ tags: - name: Blockchain Public Address description: API operations to manage Blockchain Public Addresses paths: - /blockchain-public-addresses: - get: + /blockchain-public-addresses/retrieve-blockchains: + post: tags: - Blockchain Public Address summary: Retrieves Blockchain Public Address associated with a mobile phone number. @@ -60,8 +60,13 @@ paths: - openId: - blockchain-public-address:read parameters: - - $ref: "#/components/parameters/PhoneNumber" - $ref: "#/components/parameters/x-correlator" + requestBody: + content: + application/json: + schema: + $ref: "#/components/schemas/PhoneNumber" + required: true responses: "200": description: OK @@ -104,6 +109,7 @@ paths: $ref: "#/components/responses/Generic503" "504": $ref: "#/components/responses/Generic504" + /blockchain-public-addresses: post: tags: - Blockchain Public Address @@ -122,6 +128,7 @@ paths: application/json: schema: $ref: "#/components/schemas/BindBlockchainPublicAddressRequest" + required: true responses: "201": description: Created @@ -223,6 +230,15 @@ components: schema: type: string schemas: + PhoneNumber: + type: object + description: Payload to retrieve the Blockchain Public Address(es) associated to a given Phone Number + required: + - phoneNumber + properties: + phoneNumber: + type: string + description: A public identifier addressing a telephone subscription. In mobile networks it corresponds to the MSISDN (Mobile Station International Subscriber Directory Number). In order to be globally unique it has to be formatted in international format, according to E.164 standard, prefixed with '+'. BindBlockchainPublicAddressRequest: type: object description: Payload to request the Bind of the Blockchain Public Address From c13598fe82de2bfcc95453cf2e65700b4d883c06 Mon Sep 17 00:00:00 2001 From: PEDRO DIEZ GARCIA Date: Fri, 8 Nov 2024 16:35:47 +0100 Subject: [PATCH 2/2] Issue59_adding_aleph_zero_network --- code/API_definitions/blockchain-public-address.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/code/API_definitions/blockchain-public-address.yaml b/code/API_definitions/blockchain-public-address.yaml index 44558be..9fb9e9a 100644 --- a/code/API_definitions/blockchain-public-address.yaml +++ b/code/API_definitions/blockchain-public-address.yaml @@ -268,6 +268,7 @@ components: - `ethereum` blockchain would be identified by `evm:1` value (i.e. ethereum mainnet). - `polygon` blockchain would be identified by `evm:137` value (i.e. polygon mainnet). - `celo` blockchain would be identified by `evm:42220` value (i.e. celo mainnet). + - `aleph zero` blockchain would be identified by `evm:41455` value (i.e. aleph zero evm). - `bitcoin`: Representing Bitcoin L1 blockchain. No `` concept applies for this L1 Ecosystem - `solana`: Representing Solana L1 blockchain. No `` concept applies for this L1 Ecosystem - `cardano`: Representing Cardano L1 blockchain. No `` concept applies for this L1 Ecosystem @@ -319,6 +320,7 @@ components: - `ethereum` blockchain would be identified by `evm:1` value (i.e. ethereum mainnet). - `polygon` blockchain would be identified by `evm:137` value (i.e. polygon mainnet). - `celo` blockchain would be identified by `evm:42220` value (i.e. celo mainnet). + - `aleph zero` blockchain would be identified by `evm:41455` value (i.e. aleph zero evm). - `bitcoin`: Representing Bitcoin L1 blockchain. No `` concept applies for this L1 Ecosystem - `solana`: Representing Solana L1 blockchain. No `` concept applies for this L1 Ecosystem - `cardano`: Representing Cardano L1 blockchain. No `` concept applies for this L1 Ecosystem