-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should error 429 (TOO_MANY_REQUESTS) be mandatory in CAMARA specifications? #365
Comments
HI @rartych - I can't see a 429 discussion in that TSC minutes link, please can you check?
This seems to be not aligned with RFC6585 sections 4 and 7.2:
Rather, |
@Kevsy Thank you for clarification. I have prepared table comparing how Error 429 was defined in Fall24 meta-release: https://lf-camaraproject.atlassian.net/wiki/x/0gC_Aw For Spring25 meta-release we need guidelines about removing GENERIC_429_QUOTA_EXCEEDED (as non mandatory) or keeping it according to API functionality. Subprojects need to reshape error definitions to use enums anyway for the release preparation: https://lf-camaraproject.atlassian.net/wiki/x/AYC3Aw |
Our view on that is that 429 code can be documented as non-mandatory taking advantage of ongoing PR #374. And let subprojects decide on whether this exception is relevant to be documented in API Spec. |
Thank you @PedroDiez . |
Problem description
The changes introduced in https://github.com/camaraproject/Commonalities/pull/329/files require to define Error status 429 TOO_MANY_REQUESTS in every API specification.
The purpose of it is mainly to inform about exceeded quota limits for given API Consumer.
Expected action
Verify the requirement - if this error status should be included in every specification.
Additional context
Error status 429 can be used also used by API platform to inform about overload conditions.
Discussed by TSC.
The text was updated successfully, but these errors were encountered: