Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message field and description for Error 429 not upated in subscription template #392

Closed
rartych opened this issue Jan 27, 2025 · 2 comments · Fixed by #407 or #408
Closed

Message field and description for Error 429 not upated in subscription template #392

rartych opened this issue Jan 27, 2025 · 2 comments · Fixed by #407 or #408
Assignees
@PedroDiez
Labels
correction correction in documentation Spring25

Comments

@rartych
Copy link
Collaborator

rartych commented Jan 27, 2025

Problem description
The changes in #390 are missing in event-subscription-template.yaml

Expected behavior
Align event-subscription-template.yaml with API Design Guidelines

  • 429 QUOTA_EXCEEDED for business quota limit
  • 429 TOO_MANY_REQUESTS for rate limiting (e.g., per minute, per hour, per day) or spike arrest limits

Additional context
API Design Guidelines are normative, so take precedence over artifacts.
@rartych rartych added the correction correction in documentation label Jan 27, 2025
@PedroDiez
Copy link
Collaborator

I am generating PR for this issue week

@PedroDiez PedroDiez mentioned this issue Feb 5, 2025
Merged
2 tasks
@PedroDiez
Copy link
Collaborator

Reviewed notification-as-cloud-event.yaml and will also generate a PR to align it

@PedroDiez PedroDiez mentioned this issue Feb 5, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PedroDiez PedroDiez

Labels
correction correction in documentation Spring25
Projects
None yet
Milestone
No milestone
2 participants
@PedroDiez @rartych