Add basic testcases for the new APIs conncted-network-type and connected-network-type-subscriptions #251

dfischer-tech · 2025-01-25T18:31:09Z

What type of PR is this?

Add one of the following kinds:

enhancement/feature

What this PR does / why we need it:

In order to participate in the next meta release, we need basic test cases for the new APIs.
Fixed typos and format issues in the existing ones.

Which issue(s) this PR fixes:

Fixes #234

bigludo7

I've one comment common to all 3 subscriptions for SUBSCRIPTION_MISMATCH UC.
This is not related to the device token but to the event type "consented" vs requested.

code/Test_definitions/connected-network-type-subscriptions.feature

code/Test_definitions/device-reachability-status-subscriptions.feature

code/Test_definitions/device-roaming-status-subscriptions.feature

maxl2287

LGTM

code/Test_definitions/connected-network-type-subscriptions.feature

bigludo7

Look good for me.
Thanks @dfischer-tech

Note that it could be unsupported or unauthorized. Indeed for me the error is triggered as long as the event type(s) linked to the token are not aligned with event type in the request. But I'm fine with your proposal.

code/Test_definitions/connected-network-type-subscriptions.feature

code/Test_definitions/connected-network-type.feature

code/Test_definitions/device-roaming-status-subscriptions.feature

code/Test_definitions/device-roaming-status.feature

code/Test_definitions/device-reachability-status.feature

maxl2287

LGTM

@bigludo7 @akoshunyadi @eric-murray can we get this approved / merged asap so that we can progress on the Pre-Release PR?

code/Test_definitions/connected-network-type-subscriptions.feature

…ture Co-authored-by: Eric Murray <[email protected]>

Co-authored-by: Eric Murray <[email protected]>

….feature Co-authored-by: Eric Murray <[email protected]>

Co-authored-by: Eric Murray <[email protected]>

….feature Co-authored-by: Eric Murray <[email protected]>

Co-authored-by: Eric Murray <[email protected]>

dfischer-tech · 2025-02-09T06:16:56Z

LGTM
@bigludo7 @akoshunyadi @eric-murray can we get this approved / merged asap so that we can progress on the Pre-Release PR?

I've reviewed, but changes required. Some of the test cases use the old error messages, which will be updated by #232. That PR should be merged first, and then cross-checked again with this one.

A few remarks from my side:

First of all, thank you everyone for the reviews.
This PR was solely intended to add new basic test cases for the two new APIs:
-- Connected Network Type
-- Connected Network Type Subscriptions
Adjustments to existing test cases regarding the new commonality models, version number updates or adopting the "operationId" as the request name were not within the scope of this PR.
If there is a need to integrate adjustments from Update device error model #232, this should be done in a separate PR.

bigludo7

LGTM

eric-murray

OK. Let's merge this one as well.

feat: add basic testcases

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

5e68c7e

dfischer-tech requested review from eric-murray, bigludo7, sachinvodafone and akoshunyadi as code owners January 25, 2025 18:31

akoshunyadi added the Spring25 label Jan 25, 2025

dfischer-tech added 2 commits January 26, 2025 06:10

feat: add additional testcase, fix typos and format

Loading
Loading status checks…

3f1206e

fix: add missing test case regarding fix in camaraproject#250

Loading
Loading status checks…

afe876d

bigludo7 reviewed Jan 28, 2025

View reviewed changes

code/Test_definitions/connected-network-type-subscriptions.feature Show resolved Hide resolved

code/Test_definitions/device-reachability-status-subscriptions.feature Outdated Show resolved Hide resolved

code/Test_definitions/device-roaming-status-subscriptions.feature Show resolved Hide resolved

dfischer-tech added 2 commits January 29, 2025 09:00

fix: 403 error cases revised

Loading
Loading status checks…

4999c0d

fix: 403 error cases revised

Loading
Loading status checks…

6772e5b

maxl2287 requested a review from bigludo7 January 29, 2025 09:57

maxl2287 approved these changes Jan 29, 2025

View reviewed changes

bigludo7 reviewed Jan 29, 2025

View reviewed changes

code/Test_definitions/connected-network-type-subscriptions.feature Outdated Show resolved Hide resolved

fix: SUBSCRIPTION_MISMATCH test case

Loading
Loading status checks…

89ec254

bigludo7 previously approved these changes Jan 31, 2025

View reviewed changes

akoshunyadi reviewed Feb 5, 2025

View reviewed changes

dfischer-tech and others added 2 commits February 6, 2025 11:38

Merge branch 'camaraproject:main' into main

Loading
Loading status checks…

1517353

fix: all request names to spec defined operationId

Loading
Loading status checks…

5a7d672

dfischer-tech dismissed bigludo7’s stale review via 5a7d672 February 6, 2025 11:03

maxl2287 approved these changes Feb 7, 2025

View reviewed changes

akoshunyadi previously approved these changes Feb 7, 2025

View reviewed changes

maxl2287 requested a review from bigludo7 February 7, 2025 10:45

eric-murray reviewed Feb 7, 2025

View reviewed changes

code/Test_definitions/connected-network-type-subscriptions.feature Outdated Show resolved Hide resolved

eric-murray reviewed Feb 7, 2025

View reviewed changes

code/Test_definitions/connected-network-type-subscriptions.feature Outdated Show resolved Hide resolved

eric-murray reviewed Feb 7, 2025

View reviewed changes

code/Test_definitions/connected-network-type-subscriptions.feature Outdated Show resolved Hide resolved

eric-murray reviewed Feb 7, 2025

View reviewed changes

code/Test_definitions/connected-network-type-subscriptions.feature Outdated Show resolved Hide resolved

eric-murray reviewed Feb 7, 2025

View reviewed changes

code/Test_definitions/connected-network-type-subscriptions.feature Outdated Show resolved Hide resolved

eric-murray reviewed Feb 7, 2025

View reviewed changes

code/Test_definitions/connected-network-type-subscriptions.feature Outdated Show resolved Hide resolved

eric-murray reviewed Feb 7, 2025

View reviewed changes

code/Test_definitions/connected-network-type-subscriptions.feature Outdated Show resolved Hide resolved

dfischer-tech and others added 24 commits February 9, 2025 05:34

Update code/Test_definitions/connected-network-type-subscriptions.fea…

Loading
Loading status checks…

116744b

…ture Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type-subscriptions.fea…

Loading
Loading status checks…

220b67d

…ture Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type-subscriptions.fea…

Loading
Loading status checks…

7791bcc

…ture Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type-subscriptions.fea…

Loading
Loading status checks…

5f79d82

…ture Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type-subscriptions.fea…

Loading
Loading status checks…

ffe3b14

…ture Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type.feature

Loading
Loading status checks…

26292df

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type.feature

Loading
Loading status checks…

c84fc86

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type.feature

Loading
Loading status checks…

cb00ce9

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type.feature

Loading
Loading status checks…

fd25c0f

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type.feature

Loading
Loading status checks…

1a33ffd

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type.feature

Loading
Loading status checks…

894d9f7

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/connected-network-type.feature

Loading
Loading status checks…

beceb01

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-roaming-status-subscriptions.feature

Loading
Loading status checks…

9008a22

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-reachability-status-subscriptions…

Loading
Loading status checks…

d662b66

….feature Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-reachability-status.feature

Loading
Loading status checks…

3e976fc

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-reachability-status-subscriptions…

Loading
Loading status checks…

80d3256

….feature Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-reachability-status.feature

Loading
Loading status checks…

848cac8

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-roaming-status-subscriptions.feature

Loading
Loading status checks…

0fd36e3

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-roaming-status-subscriptions.feature

Loading
Loading status checks…

a3ff221

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-roaming-status.feature

Loading
Loading status checks…

8eec1bf

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-roaming-status.feature

Loading
Loading status checks…

7758004

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-roaming-status.feature

Loading
Loading status checks…

e6f7c15

Co-authored-by: Eric Murray <[email protected]>

Update code/Test_definitions/device-roaming-status.feature

Loading
Loading status checks…

b2ef744

Co-authored-by: Eric Murray <[email protected]>

fix: order, formats, version numbers and test case 503

Loading
Loading status checks…

a217446

bigludo7 approved these changes Feb 9, 2025

View reviewed changes

maxl2287 mentioned this pull request Feb 10, 2025

Update device error model #232

Merged

akoshunyadi approved these changes Feb 10, 2025

View reviewed changes

eric-murray approved these changes Feb 10, 2025

View reviewed changes

akoshunyadi merged commit 3e4c428 into camaraproject:main Feb 10, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic testcases for the new APIs conncted-network-type and connected-network-type-subscriptions #251

Add basic testcases for the new APIs conncted-network-type and connected-network-type-subscriptions #251

dfischer-tech commented Jan 25, 2025 •

edited

Loading

bigludo7 left a comment

maxl2287 left a comment

bigludo7 left a comment

maxl2287 left a comment •

edited

Loading

dfischer-tech commented Feb 9, 2025

bigludo7 left a comment

eric-murray left a comment

Add basic testcases for the new APIs conncted-network-type and connected-network-type-subscriptions #251

Add basic testcases for the new APIs conncted-network-type and connected-network-type-subscriptions #251

Conversation

dfischer-tech commented Jan 25, 2025 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

bigludo7 left a comment

Choose a reason for hiding this comment

maxl2287 left a comment

Choose a reason for hiding this comment

bigludo7 left a comment

Choose a reason for hiding this comment

maxl2287 left a comment • edited Loading

Choose a reason for hiding this comment

dfischer-tech commented Feb 9, 2025

bigludo7 left a comment

Choose a reason for hiding this comment

eric-murray left a comment

Choose a reason for hiding this comment

dfischer-tech commented Jan 25, 2025 •

edited

Loading

maxl2287 left a comment •

edited

Loading