Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the name of the attribute middleNamesScore #161

Open
GillesInnov35 opened this issue Oct 30, 2024 · 3 comments
Open

Error in the name of the attribute middleNamesScore #161

GillesInnov35 opened this issue Oct 30, 2024 · 3 comments

Comments

@GillesInnov35
Copy link
Collaborator

Problem description
There's an error in the name of the attribute middleNamesScore - not consistent with the others, Match is missing

Expected behavior
to be consistent with the oters attributes name it must be: middleNamesMatchScore

@GillesInnov35 GillesInnov35 changed the title Attribute name middleNamesScore Error in the name of the attribute middleNamesScore Oct 30, 2024
@fernandopradocabrillo
Copy link
Collaborator

Thanks for pointing it out Gilles. This change is tricky because even it is clearly an error, fixing it breaks the compatibility, specially if the API is already being integrated, which is our case. We can discuss what could be the best approach, but I think it should be at least in a v0.3..

@GillesInnov35
Copy link
Collaborator Author

hi @fernandopradocabrillo , yes you're right there'd be a problem of backward compatibility with the correction. At Orange France we don't currently manage middle names but Spain is concerned. As you propose we can discuss in this issue about decision to be made as quicky as possible; it could be to keep the current name with the error and wait for the next version.
Thanks
BR
Gilles

@fernandopradocabrillo
Copy link
Collaborator

For us the solution of leaving it like it is right now, at least for version 0.2.1 is alright. If the rest is ok with the decission, we can include it in higher versions (i.e v0.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants