Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should the master image be the base image #4

Open
roovo opened this issue Dec 28, 2013 · 3 comments
Open

should the master image be the base image #4

roovo opened this issue Dec 28, 2013 · 3 comments

Comments

@roovo
Copy link

roovo commented Dec 28, 2013

It seems cleaner to me to tag the base image (form which other project images are built) as "base" rather than "master".

With the current system:

#             REPOSITORY          TAG                ....
#             test                master.093e707     ....
#             test                master             ....

On the last line, master just means the base image (as it could actually be a non-master git branch) but it means the git branch master in the line above. If it's called base it'd look like:

REPOSITORY          TAG                ....
test                master.093e707     ....
test                base               ....

which feels more intuitive and intent revealing. Happy to add a pull request if it makes sense to you too.

Cheers

Roovo

@gerhard
Copy link
Contributor

gerhard commented Feb 6, 2014

The reason why I've went with master is because it matches the state of a git repository. All application code is coming from git, so introducing base adds an extra mapping step. It does add indirection, yes, but is it valuable enough? I've expanded on my approach at the most recent London Docker Meetup, slides are already up, blog post will follow shortly.

As for dockerize, I've captured all the knowledge in an Ansible playbook. I regard that as the next evolution of the dockerize concept.

Thanks for weighing in on this 👍

@robodude666
Copy link

By "... Ansible Playbook. ... evolution of the dockerize concept" are you referring to your ansible-docker project?

@gerhard
Copy link
Contributor

gerhard commented Aug 28, 2014

Yes, pretty much. I've done a lot more progress since, will be updating the repo when I wrap up the second phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants