Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check output says no Safe Links/Safe Attachment policy applies to domains which are in scope of active Safe Links/Safe Attachment policies #224

Closed
damozes1 opened this issue Jun 7, 2023 · 1 comment
Assignees
Labels
as designed wontfix This will not be worked on

Comments

@damozes1
Copy link
Collaborator

damozes1 commented Jun 7, 2023

Check output incorrectly say no Safe Links/Safe attachment policy applies to domains which are in scope of active Safe Links/Safe Attachment policies
check-ORCA227.ps1
check-ORCA226.ps1

@damozes1 damozes1 changed the title Check output says no Safe Links policy applies to domains which are in scope of active Safe Links policies Check output says no Safe Links/Safe Attachment policy applies to domains which are in scope of active Safe Links/Safe Attachment policies Jun 7, 2023
@cammurray cammurray self-assigned this Jun 8, 2023
@cammurray cammurray added the bug Something isn't working label Jun 8, 2023
@cammurray cammurray added this to the 2.3 milestone Jun 8, 2023
@cammurray
Copy link
Owner

This is not a bug but a shortfall in the design.

It's just that the way that this check is coded at the moment is that it checks for domain inclusion, but ignores rules applying the policy which have exceptions. It's been this way since ORCA was born, because doing exception level checking is quite complex.

I think we will do this, and change this, but as a new bit of work and not as a bug. Tracking this in #238

@cammurray cammurray removed this from the 2.3 milestone Jun 8, 2023
@cammurray cammurray added wontfix This will not be worked on as designed and removed bug Something isn't working labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
as designed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants