[Home]: Separate homepage from datahub in two apps #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and vite as default dev server
to let them be shared by apps
allowing to use router.config in extended router.service
f-necas
reviewed
Apr 11, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
67
to
68
| docker push ghcr.io/camptocamp/mel-dataplatform/datahub:latest | ||
| docker push ghcr.io/camptocamp/mel-dataplatform/home:latest |
There was a problem hiding this comment.
I'll try to get the services and pods cleaner, is it possible to rename them as catalogue:latest and accueil:latest ?
There was a problem hiding this comment.
Sure, feel free to rename it as it fits best for the deployment
tkohr
commented
Apr 11, 2024
apps/home/project.json
Outdated
| "options": { | ||
| "commands": [ | ||
| "nx build home --base-href='/accueil/'", | ||
| "docker build -f ./tools/docker/Dockerfile . -t ghcr.io/camptocamp/mel-dataplatform/home:latest" |
There was a problem hiding this comment.
Ah and the renaming also applies for the datahub image here
Angi-Kinas
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Thank you @tkohr for this huge change! 💯
I manually tested a bit on localhost and it looks good so far. I think the actual testing has to be done after it is deployed.
|
@tkohr I pushed a small commit for image names, feel free to merge when it's ok for you :) |
f-necas
approved these changes
Apr 11, 2024
f-necas
approved these changes
Apr 11, 2024
f-necas
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to separate the homepage from the datahub in different apps to facilitate routing on the georchestra plattform.
The
homeapp should run underdatamel.fr/accueiland thedatahubapp underdatamel.fr/catalogue.To-dos:
homebundler to vite (currently webpack)app.modules: clean unused importshometestshomeimage/search?router.servicewithoutsearchusingrouter.configin router with NPM package: Allow router.config to be used in extended router services geonetwork/geonetwork-ui#845 merged => breaks updating search filters/search: Routing: Allow implementing other search routes than /search in other router services geonetwork/geonetwork-ui#850