Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol parsing caps out at 32 characters #3

Open
fixermark opened this issue Jul 25, 2020 · 1 comment
Open

Symbol parsing caps out at 32 characters #3

fixermark opened this issue Jul 25, 2020 · 1 comment

Comments

@fixermark
Copy link

fixermark commented Jul 25, 2020

If the size of a symbol exceeds the SBOLSZ - 1 limit (https://github.com/camsaul/nesasm/blob/master/source/symbol.c#L57), reading more characters for the symbol silently bails. This can cause aliasing of symbols if really_very_surprisingly_long_name and really_surprisingly_long_name_with_a_different_suffix are in the same program.

@camsaul
Copy link
Owner

camsaul commented Aug 19, 2020

Hey @fixermark, I don't have a ton of time to hunt down bugs like this myself but I'd be happy to merge a PR to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants