From 2973448c7a7bf50faa9b334308b82f302a501033 Mon Sep 17 00:00:00 2001 From: Josh Wulf Date: Tue, 25 Aug 2020 22:25:50 +1200 Subject: [PATCH] Fixes #173 --- CHANGELOG.md | 8 ++++++++ package.json | 3 +-- src/zb/ZBClient.ts | 3 --- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3154b17e..a8d3bb63 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,11 @@ +# Version 0.24.0 + +## Fixes + +_Things that were broken and are now fixed._ + +- The `segfault-handler` package dependency broke cross-architecture builds. This required users to change their build chain and caused issues with AWS lambda deployment. It was added to assist in debugging the pure JS implementation of gRPC. In this release it has been removed. See [#173](https://github.com/zeebe-io/zeebe-client-node-js/issues/173). + # Version 0.23.3 ## Breaking Changes diff --git a/package.json b/package.json index 4a6a2ca2..0bae6b4b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "zeebe-node", - "version": "v0.23.3", + "version": "v0.24.0", "description": "A Node.js client library for the Zeebe Microservices Orchestration Engine.", "keywords": [ "zeebe", @@ -72,7 +72,6 @@ "grpc": "^1.24.3", "long": "^4.0.0", "promise-retry": "^1.1.1", - "segfault-handler": "^1.3.0", "stack-trace": "0.0.10", "typed-duration": "^1.0.12", "uuid": "^3.3.2" diff --git a/src/zb/ZBClient.ts b/src/zb/ZBClient.ts index 4452718b..62cd4df1 100644 --- a/src/zb/ZBClient.ts +++ b/src/zb/ZBClient.ts @@ -5,7 +5,6 @@ import * as NEA from 'fp-ts/lib/NonEmptyArray' import { pipe } from 'fp-ts/lib/pipeable' import * as path from 'path' import promiseRetry from 'promise-retry' -import SegfaultHandler from 'segfault-handler' import { Duration, MaybeTimeDuration } from 'typed-duration' import { v4 as uuid } from 'uuid' import { @@ -39,8 +38,6 @@ import { decodeCreateZBWorkerSig } from '../lib/ZBWorkerSignature' import { ZBBatchWorker } from './ZBBatchWorker' import { ZBWorker } from './ZBWorker' -SegfaultHandler.registerHandler(`crash-${uuid()}.log`) // With no argument, SegfaultHandler will generate a generic log file name - const idColors = [ chalk.yellow, chalk.green,