Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

segfault-handler breaks cross-architecture build #173

Closed
MainAero opened this issue Aug 19, 2020 · 2 comments
Closed

segfault-handler breaks cross-architecture build #173

MainAero opened this issue Aug 19, 2020 · 2 comments

Comments

@MainAero
Copy link
Contributor

The introduced usage of segfault-handler breaks our cross-architecture build.
We didn't find any way on rebuilding segfault-handler to work in a AWS Lambda function expect the way of using a docker image. As this would introduce a lot of refactoring of our CI pipeline we decided to remove segfault-handler in our fork.

The AWS Lambda fails with:

ERROR	Error: /var/task/node_modules/segfault-handler/build/Release/segfault-handler.node: invalid ELF header
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1188:18)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Module.require (internal/modules/cjs/loader.js:1026:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at bindings (/var/task/node_modules/bindings/bindings.js:112:48)
    at Object.<anonymous> (/var/task/node_modules/segfault-handler/index.js:3:37)
    at Module._compile (internal/modules/cjs/loader.js:1138:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
    at Module.load (internal/modules/cjs/loader.js:986:32)
@bhsdodo
Copy link

bhsdodo commented Aug 24, 2020

Just to add more issues about segfault-handler package:

The library has some issues when running in Alpine Linux images:
ddopson/node-segfault-handler#70
ddopson/node-segfault-handler#67

Looks like they are not maintaining that package anymore.

@jwulf
Copy link
Member

jwulf commented Aug 25, 2020

Yah, got it. Sorry about the impact. I added it to aid in debugging the JS gRPC dependency. I'll do another release without this dependency.

@jwulf jwulf closed this as completed in 2973448 Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants