Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "compilerOptions", "include" in tsconfig.json #282

Open
katiestahl opened this issue Jul 11, 2024 · 2 comments
Open

fix "compilerOptions", "include" in tsconfig.json #282

katiestahl opened this issue Jul 11, 2024 · 2 comments
Labels
chore Changes that do not relate to a fix or feature and don't modify src or test files cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced (e.g. f priority:medium Medium priority stale-exempt technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@katiestahl
Copy link
Contributor

{ "compilerOptions": { "target": "es6", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, "esModuleInterop": true, "allowSyntheticDefaultImports": true, "strict": true, "forceConsistentCasingInFileNames": true, "noFallthroughCasesInSwitch": true, "module": "esnext", "moduleResolution": "node", "resolveJsonModule": true, "isolatedModules": true, "noEmit": true, "jsx": "react-jsx", "checkJs": true }, "include": [ "./src/**/*.ts", "global/ResponseModels.ts", "src/services/main.tsx" ] }

All/most of our typescript files in client are .tsx (not .ts), so our typescript code isn't getting properly verified/linted. It works, but since we're not actually verifying all of our frontend files, this defeats the purpose of using typescript and our linters. We need to change tsconfig.json to:
{ "compilerOptions": { "target": "es6", "baseUrl": "src", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, "esModuleInterop": true, "allowSyntheticDefaultImports": true, "strict": true, "forceConsistentCasingInFileNames": true, "noFallthroughCasesInSwitch": true, "module": "esnext", "moduleResolution": "node", "resolveJsonModule": true, "isolatedModules": true, "noEmit": true, "jsx": "react-jsx", "checkJs": true }, "include": ["src"] }

This way, all of the files will be properly checked. Additionally, this will fix #190 and allow absolute pathing for project modules.

However, making these changes breaks a LOT of things, so this ticket would be pretty hefty fixing all of the errors. I started doing this work a bit in the branch issue-190, but it's more than I have time to complete at the moment (therefore adding this issue to address at another time)

@katiestahl katiestahl added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced (e.g. f chore Changes that do not relate to a fix or feature and don't modify src or test files labels Jul 11, 2024
@katiestahl katiestahl changed the title fix compilerOptions in tsconfig.json fix compilerOptions, include in tsconfig.json Jul 11, 2024
@katiestahl katiestahl changed the title fix compilerOptions, include in tsconfig.json fix "compilerOptions", "include" in tsconfig.json Jul 11, 2024
Copy link

This issue is stale because it has been open 135 days with no activity. This issue will be closed if no further activity occurs in 14 days.

@github-actions github-actions bot added the stale label Nov 25, 2024
Copy link

github-actions bot commented Dec 9, 2024

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
@jsstevenson jsstevenson reopened this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not relate to a fix or feature and don't modify src or test files cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced (e.g. f priority:medium Medium priority stale-exempt technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Development

No branches or pull requests

2 participants