Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up DB interface elements #294

Open
jsstevenson opened this issue Nov 15, 2023 · 0 comments
Open

Clean up DB interface elements #294

jsstevenson opened this issue Nov 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jsstevenson
Copy link
Member

jsstevenson commented Nov 15, 2023 •
edited
Loading

  • create_db -> get_db or get_db_connection
  • gene.database.database gives from datetime import datetime vibes. not desirable.
  • Can we rename DynamoDbDatabase to DynamoDb or DynamoDatabase? I think it was done to be consistent with child class names ending in Database, but seems redundant to have db and database in the name
  • Change URL environment variable?
@jsstevenson jsstevenson added the enhancement New feature or request label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsstevenson