Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Transform class to Transformer for naming consistency #393

Closed
korikuzma opened this issue Oct 9, 2024 · 1 comment
Closed

Rename Transform class to Transformer for naming consistency #393

korikuzma opened this issue Oct 9, 2024 · 1 comment
Assignees
@korikuzma
Labels
chore Changes that do not relate to a fix or feature and don't modify src or test files priority:low Low priority

Comments

@korikuzma
Copy link
Member

We should rename the Transform class to Transformer (and all child classes) to follow naming conventions where class names are nouns. This was done correctly with the Harvester class.
@korikuzma korikuzma added priority:low Low priority chore Changes that do not relate to a fix or feature and don't modify src or test files labels Oct 9, 2024
@korikuzma korikuzma self-assigned this Oct 9, 2024
korikuzma added a commit that referenced this issue Oct 30, 2024
@korikuzma
chore!: rename transform class and data dir to transformers
628ed62 
close #393
korikuzma added a commit that referenced this issue Oct 30, 2024
@korikuzma
chore!: rename transform class and data dir to transformers
7a9bbbc 
close #393
@korikuzma korikuzma mentioned this issue Oct 30, 2024
Merged
korikuzma added a commit that referenced this issue Nov 4, 2024
@korikuzma
chore!: rename transform class and dirs to transformers (#396)
e3baf34 
close #393
@github-actions github-actions bot closed this as completed Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Closed by #396.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
chore Changes that do not relate to a fix or feature and don't modify src or test files priority:low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@korikuzma