Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engage pages and Takeovers scope creep? #157

Open
sparkiegeek opened this issue Mar 24, 2023 · 0 comments
Open

Engage pages and Takeovers scope creep? #157

sparkiegeek opened this issue Mar 24, 2023 · 0 comments

Comments

@sparkiegeek
Copy link
Contributor

I believe it's just ubuntu.com that uses takeovers? If so, can the code be moved to that project and not carried around by every discourse-based-docs project?

See hardcoded ubuntu.com ids - https://github.com/canonical/canonicalwebteam.discourse/blob/main/canonicalwebteam/discourse/models.py#L85

hardcoded ubuntu.com errors https://github.com/canonical/canonicalwebteam.discourse/blob/main/canonicalwebteam/discourse/app.py#L539

there's lots to point to this not belonging in this here project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant