Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make title expansion behavior uniform across hyperlinked and non-hyperlinked titles #168

Open
tmihoc opened this issue Jul 12, 2023 · 2 comments

Comments

@tmihoc
Copy link
Member

tmihoc commented Jul 12, 2023

Currently, (a) hyperlinked vs. (b) non-hyperlinked titles behave differently with respect to caret expansion:

  • For (a) you can expand by clicking either on the text or the caret.
  • For (b) you have to click on the caret specifically.

See for example the titles under https://charmhub.io/topics/canonical-observability-stack/reference

@simskij would like like (b) to be like (a) -- in both cases it should be possible to expand by clicking on either the text or the caret.

I think this behavior makes sense in general, so it would be good to roll it out across the board.

@bartaz
Copy link
Contributor

bartaz commented Nov 28, 2023

The distinction between hyperlinked and non-hyperlinked items in side navigation is on purpose.

Hyperlinked items link to their own page, that's why they are clickable. By clicking on hyperlinked item you go to the linked page. Yes, it "expands" the child items, because we show the child items of the page you just navigated to. So expanding is rather a side effect, not directly caused by clicking on hyperlinked item.

Non-hyperlinked items don't have their own page, therefore are not clickable. If we make them clickable they will be no visible difference between them and hyperlinked items, which is a UX issue. User will never know if clicking on side navigation will link to new page or just expand.

I can't talk for the design, but I believe the idea was not to mix non-hyperlinked and hyperlinked items. If you use hyperlinked (and expandable) items, all of them should be created that way (all of them should have a page they link to).

@tmihoc
Copy link
Member Author

tmihoc commented Nov 28, 2023

So expanding is rather a side effect, not directly caused by clicking on hyperlinked item.

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants