freebsd > 14.0-RELEASE uses /home not /usr/home

[dch]

In upstream the move of /usr/home to /home is documented, and there are several prior commits
that update the machinery during the installer and elsewhere.

This needs to be adjusted in cloud-init also, but only > FreeBSD 14.0-RELEASE:

cloud-init/cloudinit/distros/freebsd.py

Line 38 in 96a07fb

home_dir = "/usr/home"

Currently I'm proposing to address this as a FreeBSD ports patch, where we have
tooling to accommodate per-version patching in the ports tree:

https://reviews.freebsd.org/D47338

Should this be upstreamed to cloud-init?
If so, what sort of trick would you suggest to make this OS version-aware?

[holmanb]

Should this be upstreamed to cloud-init?

Yes, we can upstream it.

If so, what sort of trick would you suggest to make this OS version-aware?

Hmm, not sure. One approach would be to avoid carrying the patch forever by could upstreaming this change and then inverting the patch version check so that it only sets home_dir = "/usr/home" on ${OSVERSION} < 1400000. Whenever you drop support for pre-14.0 then the patch can be dropped.

Thoughts?

[emaste]

FWIW the expected EOL for the final FreeBSD 13.x release is April 30, 2026.
https://www.freebsd.org/security/#sup

inverting the patch version check

Indeed, it seems that would clearly indicate intent.