From 9117020ae82b8573a6e37c15f0d9bc67504af565 Mon Sep 17 00:00:00 2001 From: yhaliaw <43424755+yhaliaw@users.noreply.github.com> Date: Mon, 5 Jun 2023 14:30:35 +0800 Subject: [PATCH] Fix check-runners juju action (#65) --- src/charm.py | 4 ++-- tests/unit/test_charm.py | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/charm.py b/src/charm.py index a721674de..9cc18d0f2 100755 --- a/src/charm.py +++ b/src/charm.py @@ -386,10 +386,10 @@ def _on_check_runners_action(self, event: ActionEvent) -> None: runner_info = runner_manager.get_github_info() for runner in runner_info: - if runner.status == GitHubRunnerStatus.ONLINE: + if runner.status == GitHubRunnerStatus.ONLINE.value: online += 1 runner_names.append(runner.name) - elif runner.status == GitHubRunnerStatus.OFFLINE: + elif runner.status == GitHubRunnerStatus.OFFLINE.value: offline += 1 else: # might happen if runner dies and GH doesn't notice immediately diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py index 74de4924b..72e4f00af 100644 --- a/tests/unit/test_charm.py +++ b/tests/unit/test_charm.py @@ -42,10 +42,10 @@ def mock_get_latest_runner_bin_url(): def mock_get_github_info(): return [ - RunnerInfo("test runner 0", GitHubRunnerStatus.ONLINE), - RunnerInfo("test runner 1", GitHubRunnerStatus.ONLINE), - RunnerInfo("test runner 2", GitHubRunnerStatus.OFFLINE), - RunnerInfo("test runner 3", GitHubRunnerStatus.OFFLINE), + RunnerInfo("test runner 0", GitHubRunnerStatus.ONLINE.value), + RunnerInfo("test runner 1", GitHubRunnerStatus.ONLINE.value), + RunnerInfo("test runner 2", GitHubRunnerStatus.OFFLINE.value), + RunnerInfo("test runner 3", GitHubRunnerStatus.OFFLINE.value), RunnerInfo("test runner 4", "unknown"), ]