Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider improving the validation logic for each endpoint #352

Closed
wood-push-melon opened this issue Jul 10, 2024 · 2 comments
Closed

Consider improving the validation logic for each endpoint #352

wood-push-melon opened this issue Jul 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@wood-push-melon
Copy link
Contributor

Currently, the payload validation logic piles validation for each endpoint in a package, e.g. the validation in the group package.

It's somehow risky whenever endpoints are added and removed. (open/closed principle)

It should be improved. Some OOP design patterns might be helpful (e.g. strategy pattern).

@wood-push-melon wood-push-melon added the enhancement New feature or request label Jul 10, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/IAM-953.

This message was autogenerated

@shipperizer
Copy link
Contributor

a new set of API will deal with validation in a different manner, v0 API can stick with the current setup and avoid refactoring for the time being

@shipperizer shipperizer closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants