Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

katib-ui-rock is based on wrong Dockerfile #32

Closed
orfeas-k opened this issue Sep 22, 2023 · 1 comment · Fixed by #38
Closed

katib-ui-rock is based on wrong Dockerfile #32

orfeas-k opened this issue Sep 22, 2023 · 1 comment · Fixed by #38

Comments

@orfeas-k
Copy link
Contributor

It turns out we have ROCKed the wrong dockerfile for katib-ui-rock.

The katib-ui component we 've charmed is the until recently (release 0.15) called new-ui component in the upstream. We can see this in the way they produced images. Looking at the0.15 release branch, this is the dockerfile we rocked while the image we use in our charm comes from this one. With release 0.16, they removed the old ui and thus renamed previous new-ui component to ui.

Summarizing, we need to update the ROCK to be based on this dockerfile (ui from release 0.16-rc.1).
@orfeas-k orfeas-k mentioned this issue Sep 22, 2023
Closed
@orfeas-k orfeas-k changed the title katib-ui-rock is based on wrong Dockerfile katib-ui-rock is based on wrong Dockerfile Sep 22, 2023
@orfeas-k orfeas-k mentioned this issue Sep 22, 2023
Merged
orfeas-k added a commit that referenced this issue Sep 29, 2023
@orfeas-k
chore: bump Katib ROCKs version 0.15.0 -> 0.16.0-rc.1 for CKF release…
b4025fc 
… 1.8 (#33)

Bumped all ROCKs with following exceptions:
- `cert-generator` ROCK is completely removed since corresponding component 
was consolidated into `katib-controller` component. See kubeflow/katib#2185
- `katib-ui-rock` needs to be rewritten since it is now based on wrong Dockerfile. Thus,
no changes were introduced in this ROCK. See #32
- `katib-db-manager`: Diverged from upstream by keeping binary for GRPC 
health checks
This was referenced Nov 27, 2023
Open
Merged
@orfeas-k
Copy link
Contributor Author

orfeas-k commented Dec 1, 2023

See PR's description for implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update katib-ui rockcraft.yaml canonical/katib-rocks
1 participant
@orfeas-k