Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative Serving goes into active even if the Knative Operator fails to create a serving instance #50

Open
ca-scribner opened this issue Sep 27, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ca-scribner
Copy link
Contributor

If we provide incorrect configuration to knative serving, the charm still "installs" (creates a CRD) successfully and goes to active even though serving is not installed and working. This can be seen by doing:

juju add-model kubeflow

juju deploy istio-pilot --trust --channel 1.11/stable --config default-gateway=my-gateway
juju deploy istio-gateway istio-ingressgateway --trust --channel 1.11/stable --config kind=ingress
juju relate istio-pilot istio-ingressgateway

juju deploy knative-operator --trust --channel latest/edge
juju deploy knative-serving --trust --channel latest/edge --config namespace=knative-serving --config istio.gateway.name=my-gateway --config istio.gateway.namespace=not-kubeflow # <------------------incorrect gateway namespace

knative serving will go into active, but if we kubectl describe knativeserving -n knative-serving -o yaml we will see the install is incomplete. Our charm could do something similar, checking for this to be completed before saying it is active

@DomFleischmann DomFleischmann added the bug Something isn't working label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants