You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be better to re-organize the constants being used in the charm.
The constants are scattered around in different modules and tests. But some of them are duplicated.
The constants are not well organized visually and logically. They are either declared as variables in the global scope or as the charm's attributes. Besides that, some of them should not be the charm's attributes IMHO.
There are some literals flying around in the charm which could also be managed.
Proposal
It is better to isolate the constants somewhere else (e.g. in an individual module) instead of piling them in an unorganized way. Highly correlated constants could be grouped together in data structures or classes to make sense semantically and logically.
The text was updated successfully, but these errors were encountered:
Enhancement Proposal
Context
It would be better to re-organize the constants being used in the charm.
Proposal
It is better to isolate the constants somewhere else (e.g. in an individual module) instead of piling them in an unorganized way. Highly correlated constants could be grouped together in data structures or classes to make sense semantically and logically.
The text was updated successfully, but these errors were encountered: