From fc2f4940073a8e19bacb2b99fa8ba1016e076071 Mon Sep 17 00:00:00 2001 From: Andrew Scribner Date: Fri, 16 Feb 2024 11:24:55 -0500 Subject: [PATCH] edit comments in pmmlserver rock * fix a copy/paste error in the dockerfile reference * edit comments slightly to increase commonality to other, similar rocks in this repo --- pmmlserver/rockcraft.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pmmlserver/rockcraft.yaml b/pmmlserver/rockcraft.yaml index d336761..746bcd3 100644 --- a/pmmlserver/rockcraft.yaml +++ b/pmmlserver/rockcraft.yaml @@ -47,12 +47,12 @@ parts: pip install poetry==1.4.0 poetry config virtualenvs.create false - # Install the kserve and pmmlserver python packages and dependencies. + # Install the kserve package, this specific server package, and their dependencies. # # Poetry by default installs the root package as editable. This means the package # is not put into dist-packages, and when we copy dist-packages to the final rock - # we will break the kserve and pmmlserver package installs. - # We work around that by installing kserve and pmmlserver from a dummy pyproject.toml + # we will break the kserve/this server's package installs. + # We work around that by installing kserve/this server from a dummy pyproject.toml # that imports these packages as dependencies. mkdir -p ./python_env_builddir cp -rf $CRAFT_PROJECT_DIR/dummy_pyproject.toml ./python_env_builddir/pyproject.toml