diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 7d1c4a6..66e1ff6 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -6,7 +6,7 @@ on: jobs: on-pull-request: - name: Get ROCKs modified and build-scan-test them + name: Get rocks modified and build-scan-test them uses: canonical/charmed-kubeflow-workflows/.github/workflows/get-rocks-modified-and-build-scan-test-publish.yaml@main permissions: pull-requests: read diff --git a/.github/workflows/on_push.yaml b/.github/workflows/on_push.yaml index 1cfd1ec..1236fc2 100644 --- a/.github/workflows/on_push.yaml +++ b/.github/workflows/on_push.yaml @@ -9,7 +9,7 @@ on: jobs: on-push: - name: Get ROCKs modified and build-scan-test-publish them + name: Get rocks modified and build-scan-test-publish them uses: canonical/charmed-kubeflow-workflows/.github/workflows/get-rocks-modified-and-build-scan-test-publish.yaml@main permissions: pull-requests: read diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8062665..2ac9345 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,9 +10,9 @@ The KServe server images are a collection of different inference server runtimes The Dockerfile for each of these images takes advantage of how each server is defined as a poetry package, using `poetry install` in the Dockerfile directly. -## Implementation details of the ROCKs in this repo +## Implementation details of the rocks in this repo -The ROCKs for the KServe servers require some atypical workarounds, mostly due to the upstream project using poetry to install its dependencies. These are documented here in detail, and briefly noted in the rockcraft.yaml files in this repository. +The rocks for the KServe servers require some atypical workarounds, mostly due to the upstream project using poetry to install its dependencies. These are documented here in detail, and briefly noted in the rockcraft.yaml files in this repository. ### Installing Python/pip via overlay-packages @@ -70,4 +70,4 @@ The upstream install procedure results in `python` being executable, but our roc ## Integration testing the server images -For every inference server provided, upstream maintains an example usage in their [Model Serving Runtimes docs](https://kserve.github.io/website/master/modelserving/v1beta1/serving_runtime/). Each example includes a model for the given server, sample input, and an example `curl` call. These can be used for integration testing of the models without deploying KServe. See also the `README.md` files in the subdirs of this repo for some of these examples applied to our ROCKs. +For every inference server provided, upstream maintains an example usage in their [Model Serving Runtimes docs](https://kserve.github.io/website/master/modelserving/v1beta1/serving_runtime/). Each example includes a model for the given server, sample input, and an example `curl` call. These can be used for integration testing of the models without deploying KServe. See also the `README.md` files in the subdirs of this repo for some of these examples applied to our rocks. diff --git a/README.md b/README.md index 293e0e2..8fd3699 100644 --- a/README.md +++ b/README.md @@ -1,2 +1,2 @@ # kserve-rocks -ROCKs for Kserve +rocks for Kserve diff --git a/lgbserver/tox.ini b/lgbserver/tox.ini index de23c73..98c7168 100644 --- a/lgbserver/tox.ini +++ b/lgbserver/tox.ini @@ -51,4 +51,4 @@ allowlist_externals = echo commands = # TODO: Implement integration tests here - echo "WARNING: This is a placeholder test - no test is implemented here." \ No newline at end of file + echo "WARNING: This is a placeholder test - no test is implemented here." diff --git a/paddleserver/tox.ini b/paddleserver/tox.ini index de23c73..98c7168 100644 --- a/paddleserver/tox.ini +++ b/paddleserver/tox.ini @@ -51,4 +51,4 @@ allowlist_externals = echo commands = # TODO: Implement integration tests here - echo "WARNING: This is a placeholder test - no test is implemented here." \ No newline at end of file + echo "WARNING: This is a placeholder test - no test is implemented here." diff --git a/pmmlserver/tox.ini b/pmmlserver/tox.ini index de23c73..98c7168 100644 --- a/pmmlserver/tox.ini +++ b/pmmlserver/tox.ini @@ -51,4 +51,4 @@ allowlist_externals = echo commands = # TODO: Implement integration tests here - echo "WARNING: This is a placeholder test - no test is implemented here." \ No newline at end of file + echo "WARNING: This is a placeholder test - no test is implemented here." diff --git a/sklearnserver/tox.ini b/sklearnserver/tox.ini index de23c73..98c7168 100644 --- a/sklearnserver/tox.ini +++ b/sklearnserver/tox.ini @@ -51,4 +51,4 @@ allowlist_externals = echo commands = # TODO: Implement integration tests here - echo "WARNING: This is a placeholder test - no test is implemented here." \ No newline at end of file + echo "WARNING: This is a placeholder test - no test is implemented here." diff --git a/storage-initializer/tox.ini b/storage-initializer/tox.ini index de23c73..98c7168 100644 --- a/storage-initializer/tox.ini +++ b/storage-initializer/tox.ini @@ -51,4 +51,4 @@ allowlist_externals = echo commands = # TODO: Implement integration tests here - echo "WARNING: This is a placeholder test - no test is implemented here." \ No newline at end of file + echo "WARNING: This is a placeholder test - no test is implemented here." diff --git a/xgbserver/tox.ini b/xgbserver/tox.ini index de23c73..98c7168 100644 --- a/xgbserver/tox.ini +++ b/xgbserver/tox.ini @@ -51,4 +51,4 @@ allowlist_externals = echo commands = # TODO: Implement integration tests here - echo "WARNING: This is a placeholder test - no test is implemented here." \ No newline at end of file + echo "WARNING: This is a placeholder test - no test is implemented here."