-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single node support #319
Single node support #319
Conversation
|
dc35488
to
b41c76f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only two small comments.
What is missing when it comes to adding existing services? Do you think about something like deploying a single node MicroCloud without OVN and then adding OVN to it later using service add
?
Should the option of single node MicroCloud also be reflected in the docs? I was thinking about something like https://canonical-microcloud.readthedocs-hosted.com/en/latest/microovn/tutorial/single-node/.
The PRs description still says Ceph will be skipped but after #378 got merged I think this sentence can be removed too.
As mentioned earlier the only other thing I found with this PR is adding services (like MicroOVN) after the single node MicroCloud is deployed seems to be not working currently. It reports
|
@roosterfish Ah I see, it's just a miscommunication. For example, if MicroOVN was not installed when You get the error For example: snap remove microovn --purge
microcloud init
...
snap install microovn
microcloud service add We've been discussing adding a |
Thanks I see but is it a bug that MicroCloud initializes MicroOVN as you can see in the output above I have proactively answered It gave me a single node MicroCloud using fan networking so I would suspect MicroCloud doesn't even look at MicroOVN in this situation. |
Configure != Initialize. MicroCloud will form the MicroOVN cluster if the snap is installed irrespective of whether or not you want to configure the network in LXD at the precise moment you ran |
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sunbeam uses very similar approach and can do microceph in one node. Can't the same be done for microcloud? |
If you're referring to the line in the PR description about MicroCeph being skipped, that was out of date and is now removed. Single node does support MicroCeph. |
Adds basic single-node support.
This adds an initial question to
microcloud init
asking if the user wants to set up just one node.If the user enters
no
, the system will follow the ordinary setup with ZFS and OVN (or optionally a FAN network instead), but the user will not be prompted for a lookup subnet and will not be presented a list of systems.The cluster can be grown after this point by using
microcloud add
.TODO: