Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minio-service added for Charmed Kubeflow 1.8 should be moved to kfp-api to avoid bugs with deploying multiple minios at once #153

Closed
ca-scribner opened this issue Nov 15, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ca-scribner
Copy link
Contributor

Bug Description

[the minio-service added to minio charm to fix an upstream kfp bug]

while prepping for the KF 1.8 release, minio-operator 151 added a new service called minio-service to the minio charm. This service was added because upstream kubeflow pipelines has an issue where it hard-codes the minio service name.

I propose we revert minio-operator 151 and instead fix the bug in kfp by adding this svc/minio-service to the kfp-api charm. The main reasons are:

  • as-is, we cannot deploy two instances of the minio charm in the same model (both minio's will deploy a service of the same name, at best with one overwriting the other). This is an issue because sometimes we have a minio for kubeflow + another minio for mlflow
  • as-is, the service that fixes a kfp bug is added for everyone, not just kfp. If we deploy mlflow+minio, the service is added anyway even though it isn't needed

In general, the minio-service is something not needed by minio, just to fix a kfp bug, so it doesn't feel right imo to put it in the minio charm

To Reproduce

Environment

Relevant Log Output

-

Additional Context

No response

@ca-scribner ca-scribner added the bug Something isn't working label Nov 15, 2023
ca-scribner added a commit to canonical/kfp-operators that referenced this issue Nov 17, 2023
This adds to kfp-api a service called `minio-service` which points to the related object-storage's s3 service.  This has been added to address a bug in upstream kfp, as explained [here](canonical/minio-operator#151).  This service was originally added to the minio charm in [minio pr 151](canonical/minio-operator#151), but has been refactored so it is added here instead as described in [minio issue 153](canonical/minio-operator#153).
ca-scribner added a commit to canonical/kfp-operators that referenced this issue Nov 20, 2023
This adds to kfp-api a service called `minio-service` which points to the related object-storage's s3 service.  This has been added to address a bug in upstream kfp, as explained [here](canonical/minio-operator#151).  This service was originally added to the minio charm in [minio pr 151](canonical/minio-operator#151), but has been refactored so it is added here instead as described in [minio issue 153](canonical/minio-operator#153).

(cherry picked from commit 12572ca)
ca-scribner added a commit to canonical/kfp-operators that referenced this issue Nov 22, 2023
This adds to kfp-api a service called `minio-service` which points to the related object-storage's s3 service.  This has been added to address a bug in upstream kfp, as explained [here](canonical/minio-operator#151).  This service was originally added to the minio charm in [minio pr 151](canonical/minio-operator#151), but has been refactored so it is added here instead as described in [minio issue 153](canonical/minio-operator#153).
@NohaIhab
Copy link
Contributor

closed by #154 and canonical/kfp-operators#387
Issue canonical/kfp-operators#389 is still open to track the upstream bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants