From 3d2ebfafbe6d108a84da6aa16be0fc5fe0e82fe6 Mon Sep 17 00:00:00 2001
From: Kayra <kayra.gemalmaz@canonical.com>
Date: Wed, 14 Aug 2024 16:44:01 +0300
Subject: [PATCH] fix: properly handle errors when posting CSR's (#55)

---
 ui/src/app/certificate_requests/asideForm.tsx | 24 +++++++++++++++----
 ui/src/app/queries.ts                         |  3 ++-
 2 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/ui/src/app/certificate_requests/asideForm.tsx b/ui/src/app/certificate_requests/asideForm.tsx
index 078f1c6..85e1791 100644
--- a/ui/src/app/certificate_requests/asideForm.tsx
+++ b/ui/src/app/certificate_requests/asideForm.tsx
@@ -8,15 +8,21 @@ import { AsideContext } from "../aside";
 export default function CertificateRequestsAsidePanel(): JSX.Element {
     const asideContext = useContext(AsideContext)
     const [cookies, setCookie, removeCookie] = useCookies(['user_token']);
+    const [errorText, setErrorText] = useState<string>("")
     const queryClient = useQueryClient()
     const mutation = useMutation(postCSR, {
         onSuccess: () => {
+            setErrorText("")
             asideContext.setIsOpen(false)
             queryClient.invalidateQueries('csrs')
         },
+        onError: (e: Error) => {
+            setErrorText(e.message)
+        }
     })
     const [CSRPEMString, setCSRPEMString] = useState<string>("")
     const handleTextChange = (event: ChangeEvent<HTMLTextAreaElement>) => {
+        setErrorText("")
         setCSRPEMString(event.target.value);
     }
     const handleFileChange = (event: ChangeEvent<HTMLInputElement>) => {
@@ -53,7 +59,7 @@ export default function CertificateRequestsAsidePanel(): JSX.Element {
                         <input type="file" name="upload" accept=".pem,.csr" onChange={handleFileChange}></input>
                     </div>
                     <div className="p-form__group row">
-                        <SubmitCSR csrText={CSRPEMString} onClickFunc={() => mutation.mutate({ authToken: cookies.user_token, csr: CSRPEMString })} />
+                        <SubmitCSR csrText={CSRPEMString} errorText={errorText} onClickFunc={() => mutation.mutate({ authToken: cookies.user_token, csr: CSRPEMString })} />
                     </div>
                 </form>
             </div>
@@ -61,18 +67,28 @@ export default function CertificateRequestsAsidePanel(): JSX.Element {
     )
 }
 
-function SubmitCSR({ csrText, onClickFunc }: { csrText: string, onClickFunc: any }) {
+function SubmitCSR({ csrText, errorText, onClickFunc }: { csrText: string, errorText: string, onClickFunc: any }) {
     let csrIsValid = false
     try {
         extractCSR(csrText.trim())
         csrIsValid = true
     }
     catch { }
-
     const validationComponent = csrText == "" ? <></> : csrIsValid ? <div><i className="p-icon--success"></i>Valid CSR</div> : <div><i className="p-icon--error"></i>Invalid CSR</div>
-    const buttonComponent = csrIsValid ? <button className="p-button--positive u-float-right" name="submit" onClick={onClickFunc} >Submit</button> : <button className="p-button--positive u-float-right" name="submit" disabled={true} onClick={onClickFunc} >Submit</button>
+    const buttonComponent = csrIsValid ? (
+        <button className="p-button--positive u-float-right" name="submit" onClick={(e) => { e.preventDefault(); onClickFunc() }} > Submit</button >
+    ) : (
+        <button className="p-button--positive u-float-right" name="submit" disabled={true} onClick={(e) => { e.preventDefault(); onClickFunc() }} >Submit</button>)
     return (
         <>
+            {errorText != "" &&
+                <div className="p-notification--negative">
+                    <div className="p-notification__content">
+                        <h5 className="p-notification__title">Error</h5>
+                        <p className="p-notification__message">{errorText.split("error: ")}</p>
+                    </div>
+                </div>
+            }
             {validationComponent}
             {buttonComponent}
         </>
diff --git a/ui/src/app/queries.ts b/ui/src/app/queries.ts
index 7940ae1..bc82f1c 100644
--- a/ui/src/app/queries.ts
+++ b/ui/src/app/queries.ts
@@ -39,7 +39,8 @@ export async function postCSR(params: { authToken: string, csr: string }) {
         body: params.csr.trim()
     })
     if (!response.ok) {
-        throw new Error(`${response.status}: ${HTTPStatus(response.status)}`)
+        const responseText = await response.text()
+        throw new Error(`${response.status}: ${HTTPStatus(response.status)}. ${responseText}`)
     }
     return response.json()
 }