Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add promtool check rules to o11y CI #12

Open
NohaIhab opened this issue Nov 1, 2022 · 2 comments · May be fixed by #22
Open

Add promtool check rules to o11y CI #12

NohaIhab opened this issue Nov 1, 2022 · 2 comments · May be fixed by #22
Labels
Priority: Low Type: Enhancement

Comments

@NohaIhab
Copy link

NohaIhab commented Nov 1, 2022

Enhancement Proposal

Might be useful for detecting syntax errors: promtool check rules.
@sed-i
Copy link
Contributor

sed-i commented Nov 2, 2022 •
edited
Loading

Apparently there's an action for that:

@sed-i sed-i transferred this issue from canonical/cos-lite-bundle Nov 2, 2022
@simskij
Copy link
Member

simskij commented Nov 2, 2022

This is an excellent idea! We should do this.

@sed-i sed-i linked a pull request Jan 11, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(ci): validate alert rules canonical/observability
3 participants
@simskij @NohaIhab @sed-i